-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-105235: Prevent reading outside buffer during mmap.find() #105252
Conversation
sweeneyde
commented
Jun 2, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Off-by-one memory error in a string fastsearch since 3.11 #105235
Hey, just want to add my two cents. Instead of using There is also another option is to use |
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 8b4a3d2 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 1ac84ce 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
A summary of buildbot failures:
|
Thanks @sweeneyde for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ythonGH-105252) * Add a special case for s[-m:] == p in _PyBytes_Find * Add tests for _PyBytes_Find * Make sure that start <= end in mmap.find (cherry picked from commit ab86426) Co-authored-by: Dennis Sweeney <[email protected]>
GH-106708 is a backport of this pull request to the 3.12 branch. |
Sorry, @sweeneyde, I could not cleanly backport this to |
GH-106710 is a backport of this pull request to the 3.11 branch. |
…H-105252) (#106708) gh-105235: Prevent reading outside buffer during mmap.find() (GH-105252) * Add a special case for s[-m:] == p in _PyBytes_Find * Add tests for _PyBytes_Find * Make sure that start <= end in mmap.find (cherry picked from commit ab86426) Co-authored-by: Dennis Sweeney <[email protected]>
|